Skip to content

honeycomb: Migrate to by-name #396592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Apr 21, 2025
Merged

honeycomb: Migrate to by-name #396592

Aleksanaa merged 1 commit into from
Apr 21, 2025

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Apr 6, 2025 •
edited
Loading

Migrate honeycomb packages to by-name

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@guylamar2006 guylamar2006 force-pushed the move-honeycomb branch 2 times, most recently from fd3e032 to 1033fbe Compare April 6, 2025 16:39
@guylamar2006
Copy link
Contributor Author

guylamar2006 commented Apr 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396592

x86_64-linux

✅ 3 packages built:
  • honeymarker
  • honeytail
  • honeyvent

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 6, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@guylamar2006
honeycomb: Migrate to by-name
f32e350 
Fix scripts

Fix formatting.

run nixfmt on scripts.
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 8, 2025
@Aleksanaa Aleksanaa merged commit 17293cd into NixOS:master Apr 21, 2025
27 checks passed
@guylamar2006 guylamar2006 deleted the move-honeycomb branch April 21, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guylamar2006 @wegank @Aleksanaa