Skip to content

adios2: init at 2.10.2 #396703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickCao merged 1 commit into from
Apr 20, 2025
Merged

adios2: init at 2.10.2 #396703

NickCao merged 1 commit into from
Apr 20, 2025

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Apr 7, 2025 •
edited
Loading

data engine for FEM software fenics-dolphinx.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 7, 2025
@nix-owners nix-owners bot requested a review from natsukium April 7, 2025 01:12
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 7, 2025
@github-actions github-actions bot removed the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Apr 9, 2025
@qbisi qbisi force-pushed the adios2 branch 6 times, most recently from d2cbfdc to 500fbe7 Compare April 12, 2025 02:29
@qbisi qbisi requested a review from NickCao April 13, 2025 14:42
NickCao
NickCao reviewed Apr 13, 2025
View reviewed changes
@qbisi qbisi requested a review from NickCao April 13, 2025 15:05
NickCao
NickCao approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, waiting for ofborg.

@qbisi qbisi requested a review from NickCao April 13, 2025 15:41
@NickCao
Copy link
Member

NickCao commented Apr 14, 2025

@ofborg build adios2

@NickCao NickCao merged commit 2f36571 into NixOS:master Apr 20, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@NickCao NickCao Awaiting requested review from NickCao

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qbisi @NickCao