Skip to content

Conversation

@commiterate
Copy link
Contributor

Things done

Switch from rec to finalAttrs. Run tests.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@commiterate commiterate changed the title fleeting-plugin-aws: Switch from rec to finalAttrs. Run tests. fleeting-plugin-aws: Switch from rec to finalAttrs. Run tests. Apr 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 8, 2025
@commiterate commiterate added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Apr 8, 2025
@commiterate commiterate force-pushed the fixup/fleeting-plugin-aws branch from 6920d8a to 246df4a Compare April 15, 2025 03:22
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 16, 2025
@commiterate commiterate force-pushed the fixup/fleeting-plugin-aws branch from f86e6dd to 4ed7895 Compare April 17, 2025 19:01
@0xda157
Copy link
Contributor

0xda157 commented Apr 17, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 396977

Logs: https://github.com/awwpotato/nixpkgs-review-gha/actions/runs/14524411709


x86_64-linux

✅ 1 package built:
  • fleeting-plugin-aws

aarch64-linux

✅ 1 package built:
  • fleeting-plugin-aws

x86_64-darwin

✅ 1 package built:
  • fleeting-plugin-aws

aarch64-darwin

✅ 1 package built:
  • fleeting-plugin-aws

Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@commiterate commiterate added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 17, 2025
@wegank wegank merged commit 586d741 into NixOS:master Apr 22, 2025
28 checks passed
@commiterate commiterate deleted the fixup/fleeting-plugin-aws branch April 22, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants