nixos/gancio: fix quotes and indentation, exec into configured user #397194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Otherwise they don't make much context when seen in docs outside of the module
SuperSandro2000
force-pushed
the
gancio-fixup
branch
from
98547a8 to
b760ece
Compare
Aleksanaa
reviewed
Apr 20, 2025
Comment on lines
+171
to
+178
| echo '#!${pkgs.runtimeShell} | ||
| cd /var/lib/gancio/ | ||
| sudo=exec | ||
| if [[ "$USER" != ${cfg.user} ]]; then | ||
| sudo="exec /run/wrappers/bin/sudo -u ${cfg.user}" | ||
| fi | ||
| $sudo ${lib.getExe cfg.package} ''${1:--help} | ||
| ' > $out/bin/gancio |
Member
There was a problem hiding this comment.
It would be better to use EOF, but fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I somehow missed the quotes when transferring this from our config to the PR 😓
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.