Skip to content

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Apr 9, 2025

The usage of electron_33 was pinned when electron_34 was the latest electron.
Now that we have electron_35 we're guaranteed to not have any more abi changes in electron_34 thus it should be fine to pin electron_34.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 9, 2025
@nix-owners nix-owners bot requested a review from ciil April 9, 2025 20:40
@b-rodrigues
Copy link
Contributor

Built and tested on both aarch64-darwin and x86_64-linux, working well!

@TomaSajt TomaSajt merged commit 92ea6fd into NixOS:master Apr 22, 2025
27 checks passed
@TomaSajt TomaSajt deleted the rstudio- branch April 24, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants