Skip to content

Conversation

@aschleck
Copy link
Contributor

@aschleck aschleck commented Apr 9, 2025

DAlphaBall computes the surface area of unions of many small balls, which is useful for software that does protein design. For example https://github.com/martinpacesa/BindCraft and https://github.com/RosettaCommons/RFDesign both depend on it. There are no proper releases of this package so I just took the latest commit.

Homepage/repository: https://github.com/outpace-bio/DAlphaBall

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aschleck aschleck marked this pull request as draft April 9, 2025 23:04
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Apr 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Apr 9, 2025
@aschleck aschleck marked this pull request as ready for review April 9, 2025 23:43
@github-actions github-actions bot added 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 9, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 10, 2025
@aschleck
Copy link
Contributor Author

@wegank is there anything else I need to do here? Thank you!

DAlphaBall computes the surface area of unions of many small balls,
which is used by software for designing protein. For example
https://github.com/martinpacesa/BindCraft and
https://github.com/RosettaCommons/RFDesign both depend on it.
@wegank
Copy link
Member

wegank commented Apr 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397514


aarch64-darwin

✅ 1 package built:
  • dalphaball

@wegank wegank merged commit 8b74f5f into NixOS:master Apr 22, 2025
26 of 29 checks passed
@aschleck aschleck deleted the dalphaball branch April 22, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants