Skip to content

Conversation

@kachick
Copy link
Member

@kachick kachick commented Apr 10, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc: @tu-maurice @ornicar


Add a 👍 reaction to pull requests you find important.

@kachick kachick marked this pull request as draft April 10, 2025 15:41
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 10, 2025
@nix-owners nix-owners bot requested a review from tu-maurice April 10, 2025 15:46
@kachick kachick marked this pull request as ready for review April 10, 2025 16:01
@kachick
Copy link
Member Author

kachick commented Apr 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397709


x86_64-linux

✅ 1 package built:
  • fishnet

aarch64-linux

✅ 1 package built:
  • fishnet

kachick added 2 commits April 11, 2025 01:30
Diff: lichess-org/fishnet@v2.9.4...v2.9.5

This patch has been generated with following command

```
nix-shell ./maintainers/scripts/update.nix --argstr package fishnet
```
Copy link
Contributor

@tu-maurice tu-maurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 12, 2025
@thiagokokada thiagokokada merged commit b38afd7 into NixOS:master Apr 19, 2025
29 checks passed
@kachick
Copy link
Member Author

kachick commented Apr 19, 2025

Thank you!

@kachick kachick deleted the update-fishnet branch April 19, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants