Skip to content

cagebreak: 2.3.1 -> 2.4.0 #397785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thiagokokada merged 5 commits into from
Apr 18, 2025
Merged

cagebreak: 2.3.1 -> 2.4.0 #397785

thiagokokada merged 5 commits into from
Apr 18, 2025

Conversation

@LudovicoPiero
Copy link
Member

@LudovicoPiero LudovicoPiero commented Apr 10, 2025 •
edited
Loading

Closes #397720

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LudovicoPiero
cagebreak: 2.3.1 -> 2.4.0
0a7e077 
Signed-off-by: Ludovico Piero <lewdovico@gnuweeb.org>
@LudovicoPiero
cagebreak: move to pkgs/by-name
35faad7 
Signed-off-by: Ludovico Piero <lewdovico@gnuweeb.org>
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 10, 2025
Gerg-L
Gerg-L reviewed Apr 11, 2025
View reviewed changes
@Gerg-L
Copy link
Contributor

Gerg-L commented Apr 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397785

x86_64-linux

✅ 1 package built:
  • cagebreak

@Gerg-L Gerg-L added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 11, 2025
berbiche
berbiche approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gerg-L Gerg-L added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 14, 2025
antonmosich
antonmosich reviewed Apr 18, 2025
View reviewed changes
@LudovicoPiero
cagebreak: use finalAttrs pattern
c152fcf 
Signed-off-by: Ludovico Piero <lewdovico@gnuweeb.org>
@LudovicoPiero
cagebreak: remove with lib;
64368ef 
Signed-off-by: Ludovico Piero <lewdovico@gnuweeb.org>
@LudovicoPiero
cagebreak: remove berbiche from maintainers
35a51b5 
See NixOS#397785 (comment)

Signed-off-by: Ludovico Piero <lewdovico@gnuweeb.org>
@Gerg-L Gerg-L added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Apr 18, 2025
@thiagokokada
Copy link
Contributor

thiagokokada commented Apr 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397785

x86_64-linux

✅ 1 package built:
  • cagebreak

@thiagokokada thiagokokada merged commit f2b33de into NixOS:master Apr 18, 2025
24 of 28 checks passed
@LudovicoPiero LudovicoPiero deleted the bump-cagebreak branch April 18, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

+3 more reviewers

@berbiche berbiche berbiche approved these changes

@antonmosich antonmosich antonmosich approved these changes

@Gerg-L Gerg-L Gerg-L approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Request: cagebreak 2.3.1 → 2.4.0

5 participants

@LudovicoPiero @Gerg-L @thiagokokada @berbiche @antonmosich