Skip to content

Conversation

@geodic
Copy link
Contributor

@geodic geodic commented Apr 10, 2025

https://github.com/Martichou/rquickshare: Rust implementation of NearbyShare/QuickShare from Android for Linux and macOS

The latest update had a disparity between the package.json and pnpm-lock.yaml files in the legacy version of the app and needed to be patched.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 10, 2025
@PerchunPak
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397803


x86_64-linux

✅ 2 packages built:
  • rquickshare
  • rquickshare-legacy

aarch64-linux

✅ 2 packages built:
  • rquickshare
  • rquickshare-legacy

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Does the app work for you? For me, it doesn't, but I assume my system is just weird

@PerchunPak PerchunPak added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 10, 2025
@geodic
Copy link
Contributor Author

geodic commented Apr 10, 2025

Intresting... I was able to run the complied binary just fine. Is the window even opening for you?

@PerchunPak
Copy link
Member

Intresting... I was able to run the complied binary just fine. Is the window even opening for you?

Yes, it just can't find my phone and my phone can't find the PC

@thiagokokada thiagokokada merged commit 4ef2c25 into NixOS:master Apr 18, 2025
29 checks passed
@geodic geodic deleted the rquickshare branch October 8, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants