Skip to content

Conversation

@JuliusFreudenberger
Copy link
Contributor

Changelog: https://github.com/gravitational/teleport/releases/tag/v17.4.3
Diff: gravitational/teleport@v17.4.2...v17.4.3

Changelog: https://github.com/gravitational/teleport/releases/tag/v16.5.1
Diff: gravitational/teleport@v16.5.0...v16.5.1

I decided to keep everything in one commit, as there are some changes in the upstream folder structure. If I have to split the updates, I would have to temporarily introduce if-else-branches for the different builds.

The folder structure change also forced me to pull a patch in-tree, so I could adapt it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 10, 2025
@techknowlogick
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397809


aarch64-darwin

✅ 4 packages built:
  • teleport (teleport_17)
  • teleport.client (teleport_17.client)
  • teleport_16
  • teleport_16.client

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 12, 2025
@techknowlogick techknowlogick added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Apr 13, 2025
@JuliusFreudenberger JuliusFreudenberger changed the title teleport_17: 17.4.2 -> 17.4.3; teleport_16: 16.5.0 -> 16.5.1 teleport_17: 17.4.2 -> 17.4.5; teleport_16: 16.5.0 -> 16.5.3 Apr 22, 2025
@arianvp
Copy link
Member

arianvp commented Apr 22, 2025

Note that you can self-merge these with @NixOS/nixpkgs-merge-bot

@JuliusFreudenberger
Copy link
Contributor Author

I can? I am not a committer and this is not in by-name, yet.

@arianvp
Copy link
Member

arianvp commented Apr 22, 2025

Ah! didn't realize this wasn't in by-name yet

@arianvp arianvp merged commit 6f725a9 into NixOS:master Apr 22, 2025
32 of 35 checks passed
@JuliusFreudenberger JuliusFreudenberger deleted the teleport_17-4-3 branch April 23, 2025 07:48
@JuliusFreudenberger
Copy link
Contributor Author

Yes, I did consider it but struggled with the Darwin SDK imports and the fact that we have several versions at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants