Skip to content

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Apr 11, 2025

Bumps the default electron version to electron_35. electron_34 will be EOL on 2025-06-24.

Related to : #295770
Previously:
#376770
#350348

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@yuyuyureka yuyuyureka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages I'm using are already using electron_35.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 11, 2025
@teutat3s
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397926


aarch64-linux

⏩ 1 package marked as broken and skipped:
  • uhk-udev-rules
❌ 4 packages failed to build:
  • cherry-studio
  • ddm
  • penpot-desktop
  • yandex-music
✅ 65 packages built:
  • antares
  • antimatter-dimensions
  • anytype
  • bilibili
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • camunda-modeler
  • caprine
  • chatd
  • drawio
  • drawio-headless
  • electron
  • electron-bin
  • electron-chromedriver
  • equibop
  • fcast-receiver
  • flaci
  • freetube
  • gdlauncher-carbon
  • gfn-electron
  • gitify
  • goofcord
  • google-chat-linux
  • httptoolkit
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kopia-ui
  • kuro
  • legcord
  • logseq
  • marktext
  • mqtt-explorer
  • nix-tour
  • obsidian
  • open-stage-control
  • openfortivpn-webview
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • pritunl-client
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • python313Packages.mkdocs-drawio-exporter
  • python313Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • ride
  • sharedown
  • sieve-editor-gui
  • siyuan
  • slacky
  • standardnotes
  • stretchly
  • super-productivity
  • uivonim
  • vesktop
  • vieb
  • voicevox
  • webtorrent_desktop
  • youtube-music
  • ytdownloader
  • zap-chip-gui
  • zepp-simulator

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 12, 2025
@teutat3s
Copy link
Member Author

penpot-desktop build failure should be fixed once this PR is merged: #396872.

@teutat3s teutat3s added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Apr 12, 2025
@pbsbot
Copy link

pbsbot commented Apr 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397926


x86_64-linux

❌ 2 packages failed to build:
  • ddm
  • yandex-music
✅ 80 packages built:
  • affine-bin
  • antares
  • antimatter-dimensions
  • anytype
  • bilibili
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • bs-manager
  • camunda-modeler
  • caprine
  • chatd
  • cherry-studio
  • drawio
  • drawio-headless
  • electron
  • electron-bin
  • electron-chromedriver
  • equibop
  • fcast-receiver
  • flaci
  • follow
  • freetube
  • gdlauncher-carbon
  • gfn-electron
  • gitify
  • goofcord
  • google-chat-linux
  • headset
  • httptoolkit
  • itch
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kopia-ui
  • kuro
  • legcord
  • logseq
  • marktext
  • morgen
  • mqtt-explorer
  • nix-tour
  • obsidian
  • open-stage-control
  • openfortivpn-webview
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • penpot-desktop
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • python313Packages.mkdocs-drawio-exporter
  • python313Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • ride
  • sharedown
  • sieve-editor-gui
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • voicevox
  • webtorrent_desktop
  • youtube-music
  • ytdownloader
  • zap-chip-gui
  • zepp-simulator

@pbsds pbsds merged commit e7d3e3b into NixOS:master Apr 19, 2025
37 checks passed
@teutat3s teutat3s deleted the electron-default-35 branch April 22, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants