Skip to content

ruri: init at 3.8 #398079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thiagokokada merged 2 commits into from
Apr 19, 2025
Merged

ruri: init at 3.8 #398079

thiagokokada merged 2 commits into from
Apr 19, 2025

Conversation

@dabao1955
Copy link
Contributor

@dabao1955 dabao1955 commented Apr 12, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 12, 2025
@dabao1955 dabao1955 force-pushed the ruri branch 4 times, most recently from 3d086bb to 7570d05 Compare April 12, 2025 08:23
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 12, 2025
Prince213
Prince213 requested changes Apr 12, 2025
View reviewed changes
Prince213
Prince213 reviewed Apr 12, 2025
View reviewed changes
Prince213
Prince213 reviewed Apr 12, 2025
View reviewed changes
@dabao1955 dabao1955 force-pushed the ruri branch 2 times, most recently from 4fa6c7a to 09c081e Compare April 12, 2025 11:02
Prince213
Prince213 requested changes Apr 12, 2025
View reviewed changes
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Apr 12, 2025
Prince213
Prince213 requested changes Apr 12, 2025
View reviewed changes
@Prince213 Prince213 added the 8.has: package (new) This PR adds a new package label Apr 12, 2025
Prince213
Prince213 requested changes Apr 12, 2025
View reviewed changes
Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap the order of the two commits: first update maintainer-list.nix, then init package. Otherwise the init commit will use an undefined attribute.

@dabao1955
Copy link
Contributor Author

dabao1955 commented Apr 12, 2025

Swap the order of the two commits: first update maintainer-list.nix, then init package. Otherwise the init commit will use an undefined attribute.

Fixed.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 12, 2025
Prince213
Prince213 requested changes Apr 12, 2025
View reviewed changes
0xda157
0xda157 suggested changes Apr 12, 2025
View reviewed changes
@dabao1955 dabao1955 force-pushed the ruri branch 2 times, most recently from ad21dd3 to 7cb2efa Compare April 13, 2025 01:41
Prince213
Prince213 requested changes Apr 13, 2025
View reviewed changes
@dabao1955 dabao1955 requested review from 0xda157 and Prince213 April 13, 2025 02:33
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 14, 2025
@dabao1955
Copy link
Contributor Author

dabao1955 commented Apr 19, 2025

？

@thiagokokada thiagokokada merged commit 73072fd into NixOS:master Apr 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@Prince213 Prince213 Prince213 approved these changes

+1 more reviewer

@0xda157 0xda157 0xda157 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dabao1955 @thiagokokada @Prince213 @0xda157 @wegank @NixOSInfra