Skip to content

Conversation

@ik-nz
Copy link
Contributor

@ik-nz ik-nz commented Apr 13, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 13, 2025
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Apr 14, 2025
@ik-nz ik-nz marked this pull request as ready for review April 14, 2025 22:56
@nix-owners nix-owners bot requested review from aqrln and tomhoule April 14, 2025 23:04
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is there any reason you didn't update it all the way to 6.6.0?

@aqrln aqrln added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 15, 2025
@aqrln
Copy link
Member

aqrln commented Apr 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398270


aarch64-darwin

❌ 1 package failed to build:
  • documenso
✅ 6 packages built:
  • ghostfolio
  • nixpkgs-manual
  • pingvin-share.backend
  • prisma
  • prisma-engines
  • zipline

@aqrln
Copy link
Member

aqrln commented Apr 15, 2025

documenso fails to build for an unrelated reason and should be ignored:

ERROR: noBrokenSymlinks: the symlink /nix/store/dpxx6gsgjhdp2jblfwjp5inbn41iysqz-documenso-0.9/nod>
ERROR: noBrokenSymlinks: the symlink /nix/store/dpxx6gsgjhdp2jblfwjp5inbn41iysqz-documenso-0.9/nod>
ERROR: noBrokenSymlinks: the symlink /nix/store/dpxx6gsgjhdp2jblfwjp5inbn41iysqz-documenso-0.9/nod>
ERROR: noBrokenSymlinks: the symlink /nix/store/dpxx6gsgjhdp2jblfwjp5inbn41iysqz-documenso-0.9/nod>
ERROR: noBrokenSymlinks: the symlink /nix/store/dpxx6gsgjhdp2jblfwjp5inbn41iysqz-documenso-0.9/nod>
ERROR: noBrokenSymlinks: the symlink /nix/store/dpxx6gsgjhdp2jblfwjp5inbn41iysqz-documenso-0.9/nod>
ERROR: noBrokenSymlinks: the symlink /nix/store/dpxx6gsgjhdp2jblfwjp5inbn41iysqz-documenso-0.9/nod>
ERROR: noBrokenSymlinks: found 7 dangling symlinks, 0 reflexive symlinks and 0 unreadable symlinks

The same failure is present on master.

@ik-nz
Copy link
Contributor Author

ik-nz commented Apr 15, 2025

Thanks! Is there any reason you didn't update it all the way to 6.6.0?

My pleasure.

I tried, and hit an error I didn't want to get stuck on. One of the Rust deps of -engines@6.6.0 uses a language feature not stabilized until 1.86, which is forthcoming ATTOW.

It seems like that will resolve on its own, so I'll have another go at 6.6.0 before long, but in another PR.

@aqrln
Copy link
Member

aqrln commented Apr 15, 2025

Ah I see, yes, we already use trait upcasting indeed. Sounds good then.

@ik-nz
Copy link
Contributor Author

ik-nz commented Apr 17, 2025

@tomhoule Could you take a look at this please?

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Apr 17, 2025
@thiagokokada
Copy link
Contributor

@ofborg eval

@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Apr 19, 2025
@thiagokokada thiagokokada merged commit 808fdec into NixOS:master Apr 19, 2025
54 of 58 checks passed
@ik-nz ik-nz mentioned this pull request Apr 21, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants