-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
nixos/hardware/nvidia: relax conditions eager loading nvidia-uvm #398355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I confirm that this has fixed my use case (with |
88e62b0 to
da88151
Compare
eljamm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
|
|
@GaetanLepage now that we remembered https://github.com/NixOS/nixpkgs/pull/334340/files, could you please rewrite the commit message to cite the previous commit and to explain that we're making the decision to eager-load the module for all users of the open driver because otherwise we (evidently) still get confused by the error on headless configurations. If we encounter ordering issues again (loading nvidia-uvm too early) we follow up by rolling out a more granular solution. One way to achieve that might be to go forward refactoring |
da88151 to
9ad98f9
Compare
|
Done, feel free to suggest a better wording. |
6b51bfa to
ffa0a23
Compare
Fixes contingent CUDA issues with open driver: NixOS#334180 Co-authored-by: Someone Serge <else@someonex.net>
ffa0a23 to
419e4d1
Compare
Things done
Fixes contingent CUDA issues with open driver:
#334180
cc @SomeoneSerge @ConnorBaker @Atry @eljamm
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.