Skip to content

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 13, 2025

Things done

Fixes contingent CUDA issues with open driver:
#334180

cc @SomeoneSerge @ConnorBaker @Atry @eljamm

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels 6.topic: nvidia Nvidia-specific issues and fixes labels Apr 13, 2025
@GaetanLepage GaetanLepage mentioned this pull request Apr 13, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 13, 2025
@GaetanLepage
Copy link
Contributor Author

I confirm that this has fixed my use case (with mistral-rs).
Let's hope it does not break any other use cases.

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 13, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398355


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

@SomeoneSerge SomeoneSerge changed the title nixos/hardware/nvidia: eager load nvidia-uvm for open driver nixos/hardware/nvidia: relax conditions eager loading nvidia-uvm Apr 17, 2025
@SomeoneSerge
Copy link
Contributor

@GaetanLepage now that we remembered https://github.com/NixOS/nixpkgs/pull/334340/files, could you please rewrite the commit message to cite the previous commit and to explain that we're making the decision to eager-load the module for all users of the open driver because otherwise we (evidently) still get confused by the error on headless configurations. If we encounter ordering issues again (loading nvidia-uvm too early) we follow up by rolling out a more granular solution. One way to achieve that might be to go forward refactoring hardware.nvidia and disentangling it from services.xserver

@GaetanLepage
Copy link
Contributor Author

Done, feel free to suggest a better wording.

@GaetanLepage GaetanLepage force-pushed the nvidia-uvm branch 2 times, most recently from 6b51bfa to ffa0a23 Compare April 17, 2025 23:10
Fixes contingent CUDA issues with open driver:
NixOS#334180

Co-authored-by: Someone Serge <else@someonex.net>
@GaetanLepage GaetanLepage merged commit b024ced into NixOS:master Apr 17, 2025
23 of 27 checks passed
@GaetanLepage GaetanLepage deleted the nvidia-uvm branch April 17, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: hardware Drivers, Firmware and Kernels 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nvidia Nvidia-specific issues and fixes 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants