-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
nixos-rebuild: Fix quoting in build-image output, improve docs #398529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixos/doc/manual/installation/building-images-via-nixos-rebuild-build-image.chapter.md
Outdated
Show resolved
Hide resolved
nixos/doc/manual/installation/building-images-via-nixos-rebuild-build-image.chapter.md
Outdated
Show resolved
Hide resolved
nixos/doc/manual/installation/building-images-via-nixos-rebuild-build-image.chapter.md
Outdated
Show resolved
Hide resolved
1a533a2 to
942b9e6
Compare
* correct option type for `image.modules` * fix grammar * show actual output of the command to
it's just a string, not actual json. This lead to extra quoting when printing the image name, i.e.: Done. The disk image can be found in /nix/store/rynka0dxk4n6c29mggijf8cmbqzf47zh-nixos-image-amazon-25.0 5pre-git-x86_64-linux/"nixos-image-amazon-25.05pre-git-x86_64-linux.vpc"
942b9e6 to
58913b1
Compare
Member
Author
|
I hope to have addressed all outstanding feedback, so I think this might be good to merge? |
thiagokokada
approved these changes
Apr 23, 2025
|
broken nixos-rebuild, line 868, " | jq -r . " |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 1-10
This PR causes between 1 and 10 packages to rebuild on Darwin.
10.rebuild-linux: 1-10
This PR causes between 1 and 10 packages to rebuild on Linux.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't quote
imageNameinnixos-rebuild build-image. It's just a string, not actual json. This mixup - which I authored - leads to extra quoting when printing the image name, e.g.:The rest is just documentation updates