Skip to content

plutovg: init at 1.0.0 #398966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Apr 22, 2025
Merged

plutovg: init at 1.0.0 #398966

Aleksanaa merged 1 commit into from
Apr 22, 2025
+29 −0

Conversation

@hatch01
Copy link
Contributor

@hatch01 hatch01 commented Apr 15, 2025

plutovg: init at 1.0.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 15, 2025
@hatch01 hatch01 mentioned this pull request Apr 15, 2025
Merged
13 tasks
This was referenced Apr 16, 2025
Closed
Merged
uku3lig
uku3lig reviewed Apr 16, 2025
View reviewed changes
@hatch01 hatch01 force-pushed the plutovg branch 3 times, most recently from 55bbb6f to 4ca0b99 Compare April 16, 2025 15:01
@uku3lig
Copy link
Member

uku3lig commented Apr 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398966

x86_64-linux

✅ 1 package built:
  • plutovg

@uku3lig uku3lig added 8.has: package (new) This PR adds a new package 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 16, 2025
0xda157
0xda157 reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@Aleksanaa
Copy link
Member

Aleksanaa commented Apr 17, 2025

@ofborg build plutovg

@hatch01
Copy link
Contributor Author

hatch01 commented Apr 21, 2025

@Aleksanaa Just to notify you that ofborg build seems ok.

@Aleksanaa Aleksanaa merged commit a8ab892 into NixOS:master Apr 22, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@0xda157 0xda157 0xda157 left review comments

@uku3lig uku3lig uku3lig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hatch01 @uku3lig @Aleksanaa @0xda157