taskflow: fix cross build #399081
Merged
taskflow: fix cross build #399081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package's CMake setup conflates building and running tests, so we must disable test building explicitly for cross builds.
github-actions
bot
added
10.rebuild-darwin: 11-100
ofborg
bot
added
the
6.topic: cross-compilation
uninsane
reviewed
Apr 19, 2025
uninsane
approved these changes
Apr 19, 2025
khabdrick
pushed a commit
to khabdrick/nixpkgs
that referenced
this pull request
Apr 21, 2025
* taskflow: fix cross build This package's CMake setup conflates building and running tests, so we must disable test building explicitly for cross builds. * taskflow: convert to finalAttrs pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package's CMake setup conflates building and running tests, so we must disable test building explicitly for cross builds.
Note: I haven't checked whether the
checkPhasedoes anything useful here, maybe it runs more tests?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)