Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 16, 2025

Diff: callowayproject/bump-my-version@refs/tags/1.0.2...refs/tags/1.1.2

Changelog: https://github.com/callowayproject/bump-my-version/tag/1.1.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 16, 2025
@nix-owners nix-owners bot requested a review from daspk04 April 16, 2025 07:42
@daspk04
Copy link
Contributor

daspk04 commented Apr 22, 2025

Thanks @emaryn !

However the build for x86-64-darwin seems to be failing, not sure but for some reason it's building nodejs-22.14.0.

@daspk04 daspk04 requested a review from GaetanLepage April 22, 2025 16:12
@daspk04
Copy link
Contributor

daspk04 commented Apr 22, 2025

Hi @GaetanLepage !

I tried to build this locally it seems to build fine, sadly I cannot replicate the issue for the darwin any suggestion how to fix this ?

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399097


x86_64-linux

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

aarch64-linux

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

x86_64-darwin

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

aarch64-darwin

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

@GaetanLepage GaetanLepage merged commit fec17c3 into NixOS:master Apr 22, 2025
27 checks passed
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Apr 22, 2025

However the build for x86-64-darwin seems to be failing,

This was probably unrelated.

@ghost ghost deleted the bump-my-version branch April 22, 2025 23:47
@ghost ghost removed the request for review from daspk04 April 22, 2025 23:47
@ghost ghost removed 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants