Skip to content

Conversation

@Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Apr 16, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 16, 2025
@nix-owners nix-owners bot requested a review from natsukium April 16, 2025 18:39
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 16, 2025
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch from fdedfe8 to 381832b Compare April 16, 2025 19:10
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch 2 times, most recently from e92804c to 8275581 Compare April 22, 2025 06:33
@Guelakais Guelakais requested a review from drupol April 22, 2025 06:34
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch from 8275581 to 8f7d672 Compare April 22, 2025 18:08
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch from 8f7d672 to 120ce7c Compare April 22, 2025 18:25
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch 2 times, most recently from 2436bb6 to 797d846 Compare April 22, 2025 21:53
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch from 797d846 to f5cbf71 Compare April 22, 2025 22:10
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch from f5cbf71 to 90369ae Compare April 22, 2025 22:19
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch 2 times, most recently from b705488 to a78fc07 Compare April 23, 2025 11:08
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch from a78fc07 to f4204ba Compare April 23, 2025 11:34
@Guelakais Guelakais force-pushed the python313Packages.colcon-defaults branch from f4204ba to 3e63f12 Compare April 23, 2025 13:53
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399279


x86_64-linux

✅ 4 packages built:
  • python312Packages.colcon-defaults
  • python312Packages.colcon-defaults.dist
  • python313Packages.colcon-defaults
  • python313Packages.colcon-defaults.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.colcon-defaults
  • python312Packages.colcon-defaults.dist
  • python313Packages.colcon-defaults
  • python313Packages.colcon-defaults.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.colcon-defaults
  • python312Packages.colcon-defaults.dist
  • python313Packages.colcon-defaults
  • python313Packages.colcon-defaults.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.colcon-defaults
  • python312Packages.colcon-defaults.dist
  • python313Packages.colcon-defaults
  • python313Packages.colcon-defaults.dist

@GaetanLepage GaetanLepage requested a review from drupol April 23, 2025 14:03
@GaetanLepage GaetanLepage merged commit 55c6098 into NixOS:master Apr 23, 2025
23 of 27 checks passed
@Guelakais Guelakais moved this to ✅ Done in ROS 2 Apr 24, 2025
@Guelakais Guelakais added this to ROS 2 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants