Skip to content

nginxMainline: 1.27.4 -> 1.27.5 #399387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thiagokokada merged 1 commit into from
Apr 19, 2025
Merged

nginxMainline: 1.27.4 -> 1.27.5 #399387

thiagokokada merged 1 commit into from
Apr 19, 2025

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 17, 2025 •
edited
Loading

Changes: https://github.com/nginx/nginx/releases/tag/release-1.27.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from RaitoBezarius April 17, 2025 05:28
@trofi
Copy link
Contributor Author

trofi commented Apr 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399387

x86_64-linux

✅ 4 packages built:
  • nginxMainline
  • nginxMainline.doc
  • nginxQuic
  • nginxQuic.doc

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 17, 2025
@Izorkin
Copy link
Contributor

Izorkin commented Apr 17, 2025

Can now remove the zlib-ng patch and replace it with zlib-ng = zlib-ng.override { withZlibCompat = true; };

@trofi
Copy link
Contributor Author

trofi commented Apr 17, 2025

Can now remove the zlib-ng patch and replace it with zlib-ng = zlib-ng.override { withZlibCompat = true; };

Is it related to this release of nginx? Or is it an orthogonal issue? If it's orthogonal I'd suggest doing it in a separate PR.

@Izorkin
Copy link
Contributor

Izorkin commented Apr 17, 2025

Is it related to this release of nginx? Or is it an orthogonal issue?

I don't think it's related.

If it's orthogonal I'd suggest doing it in a separate PR.

Ok.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 18, 2025
@thiagokokada
Copy link
Contributor

thiagokokada commented Apr 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399387

aarch64-darwin

✅ 4 packages built:
  • nginxMainline
  • nginxMainline.doc
  • nginxQuic
  • nginxQuic.doc

@thiagokokada
Copy link
Contributor

thiagokokada commented Apr 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399387

x86_64-linux

✅ 4 packages built:
  • nginxMainline
  • nginxMainline.doc
  • nginxQuic
  • nginxQuic.doc

@thiagokokada
Copy link
Contributor

thiagokokada commented Apr 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399387

x86_64-darwin

✅ 4 packages built:
  • nginxMainline
  • nginxMainline.doc
  • nginxQuic
  • nginxQuic.doc

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 18, 2025
@thiagokokada thiagokokada merged commit d3b17bf into NixOS:master Apr 19, 2025
44 of 45 checks passed
@trofi trofi deleted the nginxMainline-update branch April 19, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

+1 more reviewer

@Izorkin Izorkin Izorkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trofi @Izorkin @thiagokokada @wegank