Skip to content

Conversation

@kmjayadeep
Copy link
Contributor

coder was moved to by-name folder in ade0f7f. But the file was renamed from default.nix to package.nix and this change is not reflected in update.sh script. This broke the auto-update bot.

I tested the change by running nix-shell maintainers/scripts/update.nix --argstr package coder. I'm not sure if i need to test anything else to approve this PR.

This is my first contribution to nixpkgs. Thank you for taking your time to review the PR!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 17, 2025
@wegank wegank merged commit a3a9b2f into NixOS:master Apr 22, 2025
27 checks passed
@kmjayadeep kmjayadeep deleted the coder-fix-update branch April 23, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants