Skip to content

Conversation

@toastal
Copy link
Contributor

@toastal toastal commented Apr 17, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@toastal toastal requested review from jfly and thoughtpolice April 17, 2025 19:51
@toastal
Copy link
Contributor Author

toastal commented Apr 17, 2025

@ofborg test movim

@toastal
Copy link
Contributor Author

toastal commented Apr 17, 2025

$ git branch --show-current
h2o-a5f5c212
$ git rev-parse HEAD
f07f594e51116aa43cd31d6cf895f1e794979fc2
$ uname -srvm
Linux 6.12.23 #1-NixOS SMP PREEMPT_DYNAMIC Thu Apr 10 12:39:41 UTC 2025 x86_64
$ nix-build -A nixosTests.h2o
/nix/store/hzj45lrz5jr0nv54anvb4xy101zvcr4h-vm-test-run-h2o-basic
/nix/store/chz2lqazl3cxb60kjnvcl1242wwv400k-vm-test-run-h2o-mruby
/nix/store/55p66vlchjiys91nn2n9i3cy54pjy5yz-vm-test-run-h2o-tls-recommendations

@toastal
Copy link
Contributor Author

toastal commented Apr 17, 2025

@ofborg test h2o

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 17, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 18, 2025
@thoughtpolice thoughtpolice merged commit 09dcb51 into NixOS:master Apr 18, 2025
24 of 36 checks passed
@toastal toastal deleted the h2o-a5f5c212 branch April 19, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants