Skip to content

Conversation

@spk
Copy link
Member

@spk spk commented Apr 18, 2025

Not available yet on darwin will show an error like

       error: blackfire does not support PHP version 8.4 on aarch64-darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 18, 2025
@spk spk requested a review from shyim April 18, 2025 14:01
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 18, 2025
@shyim shyim requested a review from drupol April 21, 2025 11:41
@drupol drupol merged commit 1bec40b into NixOS:master Apr 21, 2025
52 checks passed
@spk spk deleted the blackfire-php-prob-84 branch April 22, 2025 07:44
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 12, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-399748-to-release-24.11 origin/release-24.11
cd .worktree/backport-399748-to-release-24.11
git switch --create backport-399748-to-release-24.11
git cherry-pick -x 29b535c2fc17b76df663ac3dbaf22325e8d1425a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants