Skip to content

jrnl: fix build #399763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Apr 21, 2025
Merged

jrnl: fix build #399763

Aleksanaa merged 1 commit into from
Apr 21, 2025

Conversation

@antonmosich
Copy link
Contributor

@antonmosich antonmosich commented Apr 18, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@antonmosich
jrnl: fix build
8fa3ec8 
python3Packages.rich was updated to 14.0.0 in NixOS#395156, and jrnl requires
rich < 14, but the new version did not break anything.
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 18, 2025
@nix-owners nix-owners bot requested a review from bryanasdev000 April 18, 2025 15:10
@nadir-ishiguro
Copy link
Contributor

nadir-ishiguro commented Apr 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399763

x86_64-linux

✅ 2 packages built:
  • jrnl
  • jrnl.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 18, 2025
@Aleksanaa Aleksanaa merged commit 7ca8d88 into NixOS:master Apr 21, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryanasdev000 bryanasdev000 Awaiting requested review from bryanasdev000

1 more reviewer

@nadir-ishiguro nadir-ishiguro nadir-ishiguro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonmosich @nadir-ishiguro @wegank @Aleksanaa