Skip to content

isync: 1.5.0-unstable-2024-09-29 -> 1.5.1 #399791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drupol merged 2 commits into from
Apr 19, 2025
Merged

isync: 1.5.0-unstable-2024-09-29 -> 1.5.1 #399791

drupol merged 2 commits into from
Apr 19, 2025

Conversation

@tmuehlbacher
Copy link
Contributor

@tmuehlbacher tmuehlbacher commented Apr 18, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 18, 2025
@nix-owners nix-owners bot requested a review from primeos April 18, 2025 16:49
drupol
drupol requested changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit and the PR title need to be updated

@tmuehlbacher tmuehlbacher changed the title isync 1.5.1 isync: 1.5.0 -> 1.5.1 Apr 19, 2025
@tmuehlbacher
isync: 1.5.0-unstable-2024-09-29 -> 1.5.1
b01d034 
Fixes among other things `--dry-run` actually still making some changes.

Release notes: https://sourceforge.net/projects/isync/files/isync/1.5.1/
@tmuehlbacher
isync: stop using with lib;; fix meta.changelog
4cbe8cb 
The changelog url was trying to link to a nonexistent release for
`lib.version`.
@tmuehlbacher tmuehlbacher changed the title isync: 1.5.0 -> 1.5.1 isync: 1.5.0-unstable-2024-09-29 -> 1.5.1 Apr 19, 2025
@drupol
Copy link
Contributor

drupol commented Apr 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399791

x86_64-linux

✅ 1 package built:
  • isync

antonmosich
antonmosich approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@antonmosich antonmosich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the binary

@drupol drupol merged commit ad5b0b3 into NixOS:master Apr 19, 2025
23 of 27 checks passed
@tmuehlbacher tmuehlbacher deleted the isync-1.5.1 branch April 19, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@primeos primeos Awaiting requested review from primeos

+1 more reviewer

@antonmosich antonmosich antonmosich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmuehlbacher @drupol @antonmosich