Skip to content

beeper: fix desktop entry copy #399879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Apr 23, 2025
Merged

beeper: fix desktop entry copy #399879

Aleksanaa merged 1 commit into from
Apr 23, 2025

Conversation

@zh4ngx
Copy link
Contributor

@zh4ngx zh4ngx commented Apr 18, 2025 •
edited
Loading

Fixes #399878

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zh4ngx zh4ngx requested a review from jshcmpbll April 18, 2025 23:06
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 18, 2025
@nix-owners nix-owners bot requested a review from mjm April 18, 2025 23:09
@zh4ngx
Copy link
Contributor Author

zh4ngx commented Apr 18, 2025

@jshcmpbll I made a mistake in the last PR that got merged 😆

Aleksanaa
Aleksanaa reviewed Apr 19, 2025
View reviewed changes
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 19, 2025
@zh4ngx zh4ngx force-pushed the 399878-beeper-fix-desktop-entry-install branch from fe5347f to 56aa346 Compare April 22, 2025 22:40
@zh4ngx zh4ngx requested a review from Aleksanaa April 22, 2025 22:41
@zh4ngx zh4ngx force-pushed the 399878-beeper-fix-desktop-entry-install branch from 56aa346 to 9b5e54f Compare April 22, 2025 22:43
@Aleksanaa Aleksanaa merged commit a4c0fad into NixOS:master Apr 23, 2025
24 of 27 checks passed
@zh4ngx zh4ngx deleted the 399878-beeper-fix-desktop-entry-install branch April 23, 2025 21:53
@zh4ngx
Copy link
Contributor Author

zh4ngx commented Apr 23, 2025

As a reminder to anyone reading, this fix and #395624 both depend on #399356 to handle the postExtract correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjm mjm Awaiting requested review from mjm

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

1 more reviewer

@jshcmpbll jshcmpbll jshcmpbll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

beeper: deskop entry not correctly copied

4 participants

@zh4ngx @jshcmpbll @Aleksanaa @wegank