Skip to content

devilutionx: 1.5.3 -> 1.5.4 #399913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aanderse merged 1 commit into from
Apr 20, 2025
Merged

devilutionx: 1.5.3 -> 1.5.4 #399913

aanderse merged 1 commit into from
Apr 20, 2025

Conversation

@keenanweaver
Copy link
Member

@keenanweaver keenanweaver commented Apr 19, 2025

  • Bumps to 1.5.4

Release notes: https://github.com/diasurgical/DevilutionX/releases/tag/1.5.4
Compare: diasurgical/DevilutionX@1.5.3...1.5.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: games Gaming on NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 19, 2025
@nix-owners nix-owners bot requested review from aanderse and karolchmist April 19, 2025 01:26
Zaechus
Zaechus approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@Zaechus Zaechus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and runs normally for me

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 19, 2025
@aanderse
Copy link
Member

aanderse commented Apr 20, 2025

thanks everyone!

@aanderse aanderse merged commit 8c6e167 into NixOS:master Apr 20, 2025
27 of 28 checks passed
@karolchmist
Copy link
Member

karolchmist commented Apr 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399913

x86_64-linux

✅ 1 package built:
  • devilutionx

@keenanweaver keenanweaver deleted the devilutionx-bump branch May 29, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aanderse aanderse Awaiting requested review from aanderse

2 more reviewers

@karolchmist karolchmist karolchmist approved these changes

@Zaechus Zaechus Zaechus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: games Gaming on NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@keenanweaver @aanderse @karolchmist @Zaechus @wegank