Skip to content

fcitx5: fix cross compilation #399981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
misuzu merged 2 commits into from
May 2, 2025
Merged

fcitx5: fix cross compilation #399981

misuzu merged 2 commits into from
May 2, 2025

Conversation

@uninsane
Copy link
Contributor

@uninsane uninsane commented Apr 19, 2025

fixes nix-build -A pkgsCross.aarch64-multiplatform.fcitx5 (and its dependency, xcb-imdkit)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@uninsane uninsane added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 19, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 19, 2025
@nix-owners nix-owners bot requested a review from poscat0x04 April 19, 2025 06:52
@uninsane uninsane marked this pull request as draft April 25, 2025 03:22
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing Drivers, CUPS & Co. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: R R is a programming language for statistical computing and data visualization. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: lib The Nixpkgs function library labels Apr 25, 2025
@github-actions github-actions bot removed 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: R R is a programming language for statistical computing and data visualization. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: lib The Nixpkgs function library 6.topic: games Gaming on NixOS 6.topic: php PHP is a general-purpose scripting language geared towards web development. 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET 6.topic: tcl Dynamic, multi-paradigm programming language 6.topic: teams Relating to team creation, updates, other management actions labels Apr 25, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 25, 2025
@uninsane uninsane marked this pull request as ready for review April 25, 2025 03:26
@uninsane uninsane mentioned this pull request Apr 25, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 25, 2025
@misuzu
Copy link
Contributor

misuzu commented Apr 28, 2025

This can go to the master branch, no?

@uninsane
Copy link
Contributor Author

uninsane commented May 2, 2025 •
edited
Loading

This can go to the master branch, no?

before I retargeted it the rebuild count showed rebuild-linux: 2501-5000...

fcitx5 was very recently removed from the sdl3 closure though (#401534) -- maybe that did actually bring the rebuild count down to 11-100?

@uninsane
Copy link
Contributor Author

uninsane commented May 2, 2025

ah, #401534 does look to have substantially reduced the rebuild count. however, that changeset hasn't made it to master; it's still in staging. so if i were to retarget this PR to master, the rebuild count would go back above 500.

so: staging is the right target for this PR ☹️

misuzu
misuzu approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by building with #401980

  • pkgs.xcb-imdkit
  • pkgs.fcitx5
  • pkgsCross.riscv64.imdkit
  • pkgsCross.riscv64.fcitx5

@github-project-automation github-project-automation bot moved this to In Progress in Stdenv May 2, 2025
@misuzu misuzu merged commit cda75b3 into NixOS:staging May 2, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Stdenv May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misuzu misuzu misuzu approved these changes

@poscat0x04 poscat0x04 Awaiting requested review from poscat0x04

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

Stdenv
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uninsane @misuzu