pocket-id: make overridable

[gepbird]

Depends on #399817

See #399817 (comment) as a use case

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Aleksanaa]

Is it by design that these attributes are still outside of finalAttrs scope?

[gepbird]

If you're talking about the attributes in the let block, I'd like to keep them there, inherit them in the final derivation, and reference them with finalAttrs, I think it's more readable. I prefer not declaring those in the main derivation. If I missed your point, can you please clarify it?

[Aleksanaa]

For example, if you put them into finalAttrs, when you have to change source version, you can easily override them with

pocket-id.overrideAttrs (prev: {
  version = "0.49.0";

  src = prev.src.overrideAttrs {
    hash = "";
  };

  backend = prev.backend.overrideAttrs {
    vendorHash = "";
  };

  frontend = prev.frontend.overrideAttrs {
    npmDepsHash = "";
  };
})

So we don't have to copy definition of backend and frontend again.

[gepbird]

I see your point now. When overriding nested attributes, eg. pocket-id.frontend.src, one should be able to do:

pocket-id.overrideAttrs (prev: {
  src = prev.fetchFromGitHub {
    hash = "";
  };
})

instead of:

pocket-id.overrideAttrs (prev: {
  frontend = prev.frontend.overrideAttrs {
    src = prev.fetchFromGitHub {
      hash = "";
    };
  };
};

Thanks for the idea, it's much simpler to use!

[marcusramberg]

lgtm! :)