Skip to content

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Apr 19, 2025

NetJack is little used and basically unmaintained. libopus [1] and celt [2] are only used for NetJack.

NetJack also supports an in-house implementation, which is sample-based. This means dropping celt and opus should not actually affect any users.

[1] https://github.com/search?q=repo%3Ajackaudio%2Fjack2+opus+NOT+path%3Acommon%2FJackNet*&type=code
[2] https://github.com/search?q=repo%3Ajackaudio%2Fjack2+celt+NOT+path%3Acommon%2FJackNet*&type=code

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld requested a review from K900 April 19, 2025 08:47
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 19, 2025
@nix-owners nix-owners bot requested review from bjornfor and prusnak April 19, 2025 08:55
@LordGrimmauld
Copy link
Contributor Author

Pinged getchoo and jopejoe as they seem somewhat familiar with the audiostack around here, they maintain libopus. jack2 has no maintainers.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 17, 2025
NetJack is little used and basically unmaintained.
libopus [1] and celt [2] are only used for NetJack.

NetJack also supports an in-house implementation, which is sample-based.
This means dropping celt and opus should not actually affect any users.

[1] https://github.com/search?q=repo%3Ajackaudio%2Fjack2+opus+NOT+path%3Acommon%2FJackNet*&type=code
[2] https://github.com/search?q=repo%3Ajackaudio%2Fjack2+celt+NOT+path%3Acommon%2FJackNet*&type=code
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 26, 2025
@nix-owners nix-owners bot requested review from HarisDotParis and robsliwi June 26, 2025 20:38
@jopejoe1 jopejoe1 merged commit c3e5353 into NixOS:staging Jun 27, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants