python3Packages.pylddwrap: set pyproject = true, fix flaky build
#400032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: python
thiagokokada
force-pushed
the
pylddwrap-use-pyproject
branch
from
249541c to
6ec96df
Compare
github-actions
bot
added
10.rebuild-darwin: 0
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
thiagokokada
changed the title
pyproject = truepyproject = true, fix flaky build
github-actions
bot
added
10.rebuild-darwin: 1-10
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
thiagokokada
force-pushed
the
pylddwrap-use-pyproject
branch
from
e6b290a to
b0ad9fa
Compare
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
Ok, finally this seems to be building reliably. CC @gador for review. |
Member
|
gador
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject = trueinpython3Packages.pylddwrapto fix some warnings about deprecated usage of setuptoolspython3Packages.deal-solver, since this is a dependency forpython3Packages.icontract(that is a dependency forpython3Packages.pylddwrap)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.