Skip to content

Conversation

@SchweGELBin
Copy link
Member

@SchweGELBin SchweGELBin commented Apr 19, 2025

https://github.com/mautrix/signal/releases/tag/v0.8.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 19, 2025
@nix-owners nix-owners bot requested review from Ma27 and cyclic-pentane April 19, 2025 14:36
@Ma27 Ma27 force-pushed the mautrix-signal-0.8.2 branch from dfe5f4f to 7d643b9 Compare April 20, 2025 12:18
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 20, 2025
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that libsignal-ffi also needs an update and it needs to match exactly what mautrix-signal is using. Otherwise we're subject to unexpected bugs.

I did it myself this time since I only noticed after deploying this to my own setup for testing 🙈

@Ma27 Ma27 merged commit 1ba2b99 into NixOS:master Apr 20, 2025
23 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 20, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 20, 2025

Git push to origin failed for release-24.11 with exitcode 1

@SchweGELBin
Copy link
Member Author

Keep in mind that libsignal-ffi also needs an update and it needs to match exactly what mautrix-signal is using. Otherwise we're subject to unexpected bugs.

I did it myself this time since I only noticed after deploying this to my own setup for testing 🙈

Alright thanks. I didn't know this.

@SchweGELBin SchweGELBin deleted the mautrix-signal-0.8.2 branch April 22, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants