Skip to content

Conversation

@SchweGELBin
Copy link
Member

@SchweGELBin SchweGELBin commented Apr 19, 2025

https://github.com/mautrix/slack/releases/tag/v0.2.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 19, 2025
@nix-owners nix-owners bot requested a review from BonusPlay April 19, 2025 14:38
Copy link
Member

@BonusPlay BonusPlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks ok, but for some reason nixpkgs-review doesn't build the package for me.

@BonusPlay BonusPlay added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 20, 2025
@SchweGELBin
Copy link
Member Author

Change looks ok, but for some reason nixpkgs-review doesn't build the package for me.

Hmm, I was able to build it manually on both x86_64 and aarch64.

Maybe it failed because it depends on an insecure package olm?
This could be cirmcumvented with: (pkgs.mautrix-slack.override { withGoolm = true; }); or NIXPKGS_ALLOW_INSECURE=1

@pbsbot
Copy link

pbsbot commented Apr 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400089 --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }'


x86_64-linux

✅ 1 package built:
  • mautrix-slack

@pbsds pbsds merged commit bd910af into NixOS:master Apr 24, 2025
37 checks passed
@SchweGELBin SchweGELBin deleted the mautrix-slack-0.2.1 branch April 24, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants