bitwarden-cli: patch out advertisement in --help message

[shelvacu]

Before:

After:

pinging package maintainer: @dotlambda

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

---

x86_64-linux

✅ 13 packages built:

• bitwarden-cli
• python312Packages.jupyter-collaboration
• python312Packages.jupyter-collaboration.dist
• python312Packages.jupyter-server-ydoc
• python312Packages.jupyter-server-ydoc.dist
• python312Packages.jupyter-ydoc
• python312Packages.jupyter-ydoc.dist
• python313Packages.jupyter-collaboration
• python313Packages.jupyter-collaboration.dist
• python313Packages.jupyter-server-ydoc
• python313Packages.jupyter-server-ydoc.dist
• python313Packages.jupyter-ydoc
• python313Packages.jupyter-ydoc.dist

---

Add a 👍 reaction to pull requests you find important.

[dotlambda]

Is there precedent in nixpkgs for doing this? I don't want the ad either but it's very non-intrusive and we don't want to have a bad relationship with upstream.

[shelvacu]

I'm not familiar with any other open-source package in nixpkgs that has an advertisement like this; this usually only happens in binary-only redistributable software where it's expected to be very difficult to change it's behaviour

However, nixpkgs does regularly patch out other user-hostile behaviours like telemetry (ex) and auto-updates or update reminders (ex).

[SuperSandro2000]

I also think it is not very intrusive compared to some other annoying things and it seems to be only printed when calling the help, not eg for every command.

[shelvacu]

I don't understand what we are trying to balance. Why does it matter how "intrusive" it is? If I asked every single user of nixpkgs, "do you want this package with the ad, or without the ad?", the answer is without the ad. It's a three-line patch, likely easier to maintain than many other patches that are regularly done in nixpkgs. What's the holdup?

[SuperSandro2000]

I am trying to balance the amount of changes we do to upstream software.

I think it matters a lot how intrusive something is. I am way more inclined to remove features around tracking or that actively impact the user experience in a bad way but probably the choice of software should be reconsidered first. I would probably do the same and add a hint to my software if they work well together and wouldn't be so happy if distros would patch it out.

This is a purely cosmetic patch as some other bigger patches are required for the software to work or compile at all. I think the general idea is always to keep patching to a minimum while making the software work on nixos and also apply bug fixes where needed.

dotlamba requested my review on this PR, hence I gave it. Please discuss the granularities with him.

[dotlambda]

It's a three-line patch, likely easier to maintain than many other patches that are regularly done in nixpkgs.

Any patch, however small, might keep @r-ryantm from being able to automatically update.

[jcollie]

I agree that this is unnecessary. It's not harmful to the user like tracking or auto-updates and this could slow down getting updates if Bitwarden ever changes the message.

[SuperSandro2000]

Going to close this as @jcollie summarized it very well.