virtualbox: 7.1.6a -> 7.1.8 #400278
Merged
virtualbox: 7.1.6a -> 7.1.8 #400278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
Member
LeSuisse
added
the
1.severity: security
Contributor
Author
|
@muellerbernd could you (or someone else) please run |
|
LeSuisse
reviewed
Apr 23, 2025
| virtualboxSubVersion = ""; | ||
| virtualboxSha256 = "3f7132c55ac6c5f50585bfaa115d29e30b47ccf535cb0a12ff50214ddae2f63d"; | ||
|
|
||
| kvmPatchVersion = "20250207"; |
Member
There was a problem hiding this comment.
KVM patch for 7.1.6 still applies with 7.1.8, we might want to adjust the build to avoid breaking virtualbox-kvm
diff --git a/pkgs/applications/virtualization/virtualbox/default.nix b/pkgs/applications/virtualization/virtualbox/default.nix
index 524b873be198..6a4bddaaab2b 100644
--- a/pkgs/applications/virtualization/virtualbox/default.nix
+++ b/pkgs/applications/virtualization/virtualbox/default.nix
@@ -249,8 +249,8 @@ stdenv.mkDerivation (finalAttrs: {
++ optional enableKvm (
let
patchVboxVersion =
- # There is no updated patch for 7.0.22 yet, but the older one still applies.
- if finalAttrs.virtualboxVersion == "7.0.22" then "7.0.20" else finalAttrs.virtualboxVersion;
+ # There is no updated patch for 7.1.8 yet, but the older one still applies.
+ if finalAttrs.virtualboxVersion == "7.1.8" then "7.1.6" else finalAttrs.virtualboxVersion;
in
fetchpatch {
name = "virtualbox-${finalAttrs.virtualboxVersion}-kvm-dev-${finalAttrs.kvmPatchVersion}.patch";
Contributor
Author
There was a problem hiding this comment.
I would prefer your proposed change as a separate PR
Member
There was a problem hiding this comment.
I would prefer to have it in the same PR, as otherwise this breaks the virtualbox-kvm build needlessly. In general, we may consider moving virtualbox-kvm to a separate package, so the versions can be bumped independently when the KVM patch does not apply.
Member
There was a problem hiding this comment.
Pushed the change to re-use the 7.1.6 patch for virtualboxKvm so we do not break it.
3 tasks
Yarny0
approved these changes
Apr 26, 2025
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Review per https://github.com/NixOS/nixpkgs/tree/f771eb401a46846c1aebd20552521b233dd7e18b/pkgs#package-updates
Reviewed points
- package name fits guidelines
- package version fits guidelines
- package builds on x86-64
- executables tested on ARCHITECTURE
- all depending packages build
- patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- patches that are remotely available are fetched rather than vendored
Comments
After cherry-picking the commit onto the current nixos-unstable, I prepared a network boot image with NixOS (with the new vbox guest additions, and X11/Plasma5) and booted the image inside the new virtualbox host version on a NixOS. Works all nice for me!
wegank
added
the
12.approvals: 1
Contributor
Author
|
This PR should be merged together with #352640 |
snpschaaf
approved these changes
Apr 29, 2025
snpschaaf
added
12.approvals: 2
blitz
approved these changes
May 1, 2025
wegank
added
12.approvals: 3+
Contributor
|
Successfully created backport PR for |
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.