nixos/kmscon: add package option #400296
Merged
nixos/kmscon: add package option #400296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Contributor
Author
|
Since the module has no maintainers, i'll cc @omasanori to have a look (i hope they're alive) |
nixpkgs-ci
bot
added
the
9.needs: reviewer
Contributor
Author
|
@wolfgangwalther another maintainer hasn't been active on Github over half a year |
evysgarden
approved these changes
Sep 6, 2025
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5841 |
nixpkgs-ci
bot
added
12.approvals: 1
wolfgangwalther
requested changes
Sep 6, 2025
acid-bong
force-pushed
the
refactor/kmscon
branch
from
5a2c478 to
d3f06b7
Compare
wolfgangwalther
changed the title
Closed
3 tasks
6543
approved these changes
Sep 7, 2025
wolfgangwalther
approved these changes
Sep 7, 2025
| type = types.bool; | ||
| default = false; | ||
| }; | ||
| useXkbConfig = mkEnableOption "configure keymap from xserver keyboard settings."; |
Member
There was a problem hiding this comment.
This now reads rather odd.
Whether to enable configure keymap from xserver keyboard settings..
| }; | ||
| package = mkPackageOption pkgs "kmscon" { }; | ||
|
|
||
| hwRender = mkEnableOption "3D hardware acceleration to render the console."; |
Member
There was a problem hiding this comment.
The final dot should not be here
Whether to enable 3D hardware acceleration to render the console..
| default = false; | ||
| }; | ||
| enable = mkEnableOption '' | ||
| kmscon as the virtual console instead of gettys. |
Member
There was a problem hiding this comment.
The dot should also not be here.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packageoption (fixes Module Request: nixos/nixos/modules/services/ttys/kmscon.nix : add package override option #399859)lib.mkEnableOptionThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.