Skip to content

Conversation

@MisileLab
Copy link
Contributor

https://github.com/geldata/gel-cli/releases/tag/v7.1.0
https://github.com/geldata/gel-cli/releases/tag/v7.1.1
https://github.com/geldata/gel-cli/releases/tag/v7.2.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2025
@nix-owners nix-owners bot requested review from ahirner and kirillrdy April 20, 2025 11:06
Copy link
Contributor

@ahirner ahirner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggestion below, build fails (nix log /nix/store/b59mdmwwi6qvy0h2s5ff1p2kg34jiyfv-gel-7.2.0.drv):

@nix { "action": "setPhase", "phase": "installPhase" }
Executing cargoInstallHook
mv: cannot stat '/nix/store/j1lg4s6902wndagxgclab7hqid3cakdr-gel-7.2.0/bin/edgedb': No such file or directory

Maybe they got rid of edgedb for good and postInstall can be removed.

Edit: works after removing postInstall. If the alias wasn't meant to exist in 7, I consider this a bugfix.

@MisileLab
Copy link
Contributor Author

With the suggestion below, build fails (nix log /nix/store/b59mdmwwi6qvy0h2s5ff1p2kg34jiyfv-gel-7.2.0.drv):

@nix { "action": "setPhase", "phase": "installPhase" }
Executing cargoInstallHook
mv: cannot stat '/nix/store/j1lg4s6902wndagxgclab7hqid3cakdr-gel-7.2.0/bin/edgedb': No such file or directory

Maybe they got rid of edgedb for good and postInstall can be removed.

I'll push fix after 1~2 hours.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 22, 2025
@kirillrdy kirillrdy merged commit 6e9864b into NixOS:master Apr 22, 2025
29 checks passed
@MisileLab MisileLab deleted the gel branch April 23, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants