Skip to content

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 20, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2025
@nix-owners nix-owners bot requested a review from wegank April 20, 2025 15:32
@GaetanLepage GaetanLepage force-pushed the pybind11-protobuf branch 2 times, most recently from 7f27f92 to fbbef1d Compare April 20, 2025 16:30
Copy link
Contributor

@SomeoneSerge SomeoneSerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the tests and merge?

…ble-2025-02-10

Co-authored-by: Someone Serge <else@someonex.net>
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400350


x86_64-linux

✅ 6 packages built:
  • openroad
  • or-tools
  • or-tools.python (python312Packages.ortools, python312Packages.ortools.python)
  • python312Packages.pybind11-protobuf
  • python313Packages.ortools (python313Packages.ortools.python)
  • python313Packages.pybind11-protobuf

aarch64-linux

❌ 1 package failed to build:
  • openroad
✅ 5 packages built:
  • or-tools
  • or-tools.python (python312Packages.ortools, python312Packages.ortools.python)
  • python312Packages.pybind11-protobuf
  • python313Packages.ortools (python313Packages.ortools.python)
  • python313Packages.pybind11-protobuf

x86_64-darwin

✅ 6 packages built:
  • openroad
  • or-tools
  • or-tools.python (python312Packages.ortools, python312Packages.ortools.python)
  • python312Packages.pybind11-protobuf
  • python313Packages.ortools (python313Packages.ortools.python)
  • python313Packages.pybind11-protobuf

aarch64-darwin

✅ 6 packages built:
  • openroad
  • or-tools
  • or-tools.python (python312Packages.ortools, python312Packages.ortools.python)
  • python312Packages.pybind11-protobuf
  • python313Packages.ortools (python313Packages.ortools.python)
  • python313Packages.pybind11-protobuf

@GaetanLepage
Copy link
Contributor Author

The openroad failure on aarch64-linux seems unrelated.

@GaetanLepage GaetanLepage merged commit dfef6b0 into NixOS:master Apr 20, 2025
23 of 27 checks passed
@GaetanLepage GaetanLepage deleted the pybind11-protobuf branch April 20, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants