Skip to content

Conversation

@gileri
Copy link
Contributor

@gileri gileri commented Apr 20, 2025

Add Cortex Command Community Project.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • [] Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2025
@SigmaSquadron SigmaSquadron added the 6.topic: games Gaming on NixOS label Apr 21, 2025
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for packaging this game!

Please take a moment to review our Commit Conventions and reword your commits appropriately; their titles must follow very specific patterns as defined in our documentation. Don't forget to squash your intermediate/fixup commits.

I've left some additional review comments below.

@gileri
Copy link
Contributor Author

gileri commented Apr 21, 2025

Thanks for the comprehensive review @SigmaSquadron !
I've implemented your suggestions, and a couple more :

  • Un-vendored the patch
  • Better description

Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs, but I get a rm: remove write-protected regular file '/tmp/CCCP.RqFrk3aDP/Data'? message after running it. I'm not sure if that's intended. Still, seems alright for an init PR.

@gileri
Copy link
Contributor Author

gileri commented Apr 21, 2025

I don't have this warning when running it on either a pretty new/clean NixOS unstable, nor an Arch with Nix. I don't see what could cause this. Can you share your mount options if you have /tmp mounted separately ? When you run umask, do you get 0022 ?

I agree that even with this potential bug it could be merged, with it a standard session leaves behind about 40KiB of files in /tmp, not a huge deal.

Thank you for the quick review in any case !

@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Apr 21, 2025 via email

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 22, 2025
@SigmaSquadron SigmaSquadron reopened this Aug 19, 2025
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI...

@SigmaSquadron SigmaSquadron changed the title Add cortex-command-community-project cortex-command-community-project: init at 6.2.2 Aug 19, 2025
@SigmaSquadron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400403
Commit: 617b982c46a149754cd3d415458118cbdbfd5259


x86_64-linux

✅ 1 package built:
  • cortex-command-community-project

Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@SigmaSquadron SigmaSquadron merged commit dbee03f into NixOS:master Aug 19, 2025
50 of 53 checks passed
@SigmaSquadron
Copy link
Contributor

Thanks for your patience on this one. I was unable to merge it before, as I was not a committer for Nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants