-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
cortex-command-community-project: init at 6.2.2 #400403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SigmaSquadron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for packaging this game!
Please take a moment to review our Commit Conventions and reword your commits appropriately; their titles must follow very specific patterns as defined in our documentation. Don't forget to squash your intermediate/fixup commits.
I've left some additional review comments below.
|
Thanks for the comprehensive review @SigmaSquadron !
|
SigmaSquadron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and runs, but I get a rm: remove write-protected regular file '/tmp/CCCP.RqFrk3aDP/Data'? message after running it. I'm not sure if that's intended. Still, seems alright for an init PR.
|
I don't have this warning when running it on either a pretty new/clean NixOS unstable, nor an Arch with Nix. I don't see what could cause this. Can you share your mount options if you have I agree that even with this potential bug it could be merged, with it a standard session leaves behind about 40KiB of files in Thank you for the quick review in any case ! |
|
I have boot.tmp.useTmpfs set to true, so that must be it. Still, unlinking the folder should ideally be done by the compiled application, not by shelling out to `rm`.
|
SigmaSquadron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for CI...
|
SigmaSquadron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved automatically following the successful run of nixpkgs-review.
|
Thanks for your patience on this one. I was unable to merge it before, as I was not a committer for Nixpkgs. |
Add Cortex Command Community Project.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.