Skip to content

Conversation

@FZDSLR
Copy link
Contributor

@FZDSLR FZDSLR commented Apr 21, 2025

Things done

This fixes the criu package to support cross-compilation to loongarch64 architectures (tested on an x86 build host).

  • add new archmap for loongarch64.
  • move libuuid from nativeBuildInputs to buildInputs to pass the cross-compilation process.

The following pkgs have been tested on a x86 host:

  • pkgs.criu
  • pkgsCross.aarch64-multiplatform.criu
  • pkgsCross.loongarch64-linux.criu

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 21, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 21, 2025
@nix-owners nix-owners bot requested a review from thoughtpolice April 21, 2025 05:49
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 21, 2025
@Mindavi
Copy link
Contributor

Mindavi commented Apr 21, 2025

@ofborg build pkgsCross.aarch64-multiplatform.criu

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 22, 2025
@uninsane uninsane merged commit 3bf152c into NixOS:master Apr 22, 2025
32 of 34 checks passed
@FZDSLR FZDSLR deleted the add-criu-loongarch64-archmap branch April 23, 2025 11:07
@wegank wegank added the 6.topic: loongarch64 LoongArch, a new RISC ISA used on Loongson CPUs label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: loongarch64 LoongArch, a new RISC ISA used on Loongson CPUs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants