Skip to content

nghttp3: add meta.changelog, modernize #400618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wolfgangwalther merged 1 commit into from
Aug 16, 2025
Merged

nghttp3: add meta.changelog, modernize #400618

wolfgangwalther merged 1 commit into from
Aug 16, 2025

Conversation

@FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Apr 21, 2025

  • move to finalAttrs pattern
  • avoid using pname
  • use tag instead of rev
  • add meta.changelog
  • do not repeat package name in meta.description per style guidelines

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@FliegendeWurst FliegendeWurst requested a review from Izorkin April 21, 2025 20:21
@FliegendeWurst FliegendeWurst mentioned this pull request Apr 21, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 21, 2025
0xda157
0xda157 reviewed Apr 21, 2025
View reviewed changes
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 22, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Apr 25, 2025

Why not moving it to pkgs/by-name aside nghttp2?

@FliegendeWurst FliegendeWurst force-pushed the nghttp3-modernize branch 2 times, most recently from 9ff2e29 to b3bea81 Compare April 26, 2025 12:42
@FliegendeWurst
Copy link
Member Author

FliegendeWurst commented Apr 26, 2025

This will now create a trivial merge conflict on staging, but it should be okay.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Apr 26, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Apr 26, 2025

This will now create a trivial merge conflict on staging, but it should be okay.

I didn't know sorry 😅

Sigmanificient
Sigmanificient approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 29, 2025
@Aleksanaa Aleksanaa added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 15, 2025
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jun 9, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jun 30, 2025

This has mostly trivial changes, three approvals - and a merge conflict.

@MattSturgeon
Copy link
Contributor

MattSturgeon commented Aug 15, 2025

@FliegendeWurst I took the liberty of resolving the conflicts. Feel free to incorporate my patch into a rebase.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Aug 15, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 16, 2025

Rebased, which should also fix treefmt.

@wolfgangwalther wolfgangwalther merged commit e970daa into NixOS:master Aug 16, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

+2 more reviewers

@Izorkin Izorkin Izorkin approved these changes

@0xda157 0xda157 0xda157 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@FliegendeWurst @Sigmanificient @wolfgangwalther @MattSturgeon @Izorkin @0xda157 @wegank @Aleksanaa