Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 21, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 21, 2025
@nim65s
Copy link
Contributor

nim65s commented May 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400675


x86_64-linux

✅ 1 package built:
  • ezstream

aarch64-darwin

❌ 1 package failed to build:
  • ezstream

@nim65s
Copy link
Contributor

nim65s commented May 9, 2025

I think OfBorg only eval, and does not build / tests.
On aarch64-darwin, I got 13 test pass and 1 fail:

==========================================
   ezstream 1.0.2: tests/test-suite.log
==========================================

# TOTAL: 14
# PASS:  13
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: check_playlist
====================

Running suite(s): Playlist
May  9 17:29:31  check_playlist[10635] <Error>: nonexistent.txt: No such file or directory
May  9 17:29:31  check_playlist[10635] <Error>: ./playlist-bad.txt[1]: file or path name too long
May  9 17:29:31  check_playlist[10635] <Error>: ./playlist-bad2.txt[1]: file or path name too long
May  9 17:29:31  check_playlist[10636] <Error>: nonexistent.sh: No such file or directory
May  9 17:29:31  check_playlist[10636] <Error>: ./playlist.txt: not an executable program
./play-bad.sh: line 3: echo: write error: Broken pipe
May  9 17:29:34  check_playlist[10636] <Error>: ./play-bad.sh: output too long
66%: Checks: 3, Failures: 0, Errors: 1
check_playlist.c:84:E:Playlist:test_playlist_program:0: (after this point) Test timeout expired
FAIL check_playlist (exit status: 1)

I guess this is not a big issue, and we could ignore the check_playlist test on darwin.

@nim65s
Copy link
Contributor

nim65s commented May 10, 2025

Can you see a log in OfBorg and GitHub Action saying that the check_playlist pass on aarch64-darwin ?

@ghost ghost closed this May 10, 2025
@ghost ghost deleted the ezstream branch May 10, 2025 14:51
@ghost ghost removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 10, 2025
@nim65s
Copy link
Contributor

nim65s commented May 11, 2025

Ok, I'll try to do that. Take care.

@nim65s nim65s mentioned this pull request May 12, 2025
13 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant