Skip to content

[Backport release-24.11] dotnet: implement autoPatchcilHook #400678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corngood merged 3 commits into from
Apr 23, 2025
Merged

[Backport release-24.11] dotnet: implement autoPatchcilHook #400678

corngood merged 3 commits into from
Apr 23, 2025

Conversation

@GGG-KILLER
Copy link
Contributor

@GGG-KILLER GGG-KILLER commented Apr 21, 2025

Backport to release-24.11 of #373107.

@GGG-KILLER
patchcil: init at 0.2.2
34b7a06 
(cherry picked from commit ace0992)
@GGG-KILLER
dotnetCorePackages.autoPatchcilHook: init
6827c45 
(cherry picked from commit 84aa2c4)
@GGG-KILLER
docs/autoPatchcilHook: init
5732c0f 
(cherry picked from commit e2d963b)
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: dotnet Language: .NET labels Apr 21, 2025
@GGG-KILLER GGG-KILLER mentioned this pull request Apr 21, 2025
Merged
13 tasks
@nix-owners nix-owners bot requested a review from corngood April 21, 2025 23:04
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 21, 2025
@GGG-KILLER
Copy link
Contributor Author

GGG-KILLER commented Apr 21, 2025

The cherry-pick CI check is complaining about 2 commits. They are different because of the following reasons:

Original Backport Reason
84aa2c4 6827c45 File is different between master and 24.11. Had to move the definition around, but everything is identical.
e2d963b 5732c0f The redirects.json file doesn't exist in 24.11 so I had to remove it.

@corngood
Copy link
Contributor

corngood commented Apr 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400678

x86_64-linux

✅ 3 packages built:
  • autoPatchcilHook (dotnetCorePackages.autoPatchcilHook)
  • nixpkgs-manual
  • patchcil

@corngood corngood merged commit a43ce3b into NixOS:release-24.11 Apr 23, 2025
27 checks passed
@GGG-KILLER GGG-KILLER deleted the backport-373107-to-release-24.11 branch April 23, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corngood corngood corngood approved these changes

Assignees

No one assigned

Labels

6.topic: dotnet Language: .NET 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GGG-KILLER @corngood