Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 22, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 22, 2025
@nix-owners nix-owners bot requested a review from natsukium April 22, 2025 00:07
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@nix-owners nix-owners bot requested a review from fabaff April 22, 2025 00:14
@fabaff
Copy link
Member

fabaff commented Apr 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400696


x86_64-linux

✅ 6 packages built:
  • forbidden
  • forbidden.dist
  • python312Packages.bot-safe-agents
  • python312Packages.bot-safe-agents.dist
  • python313Packages.bot-safe-agents
  • python313Packages.bot-safe-agents.dist

@fabaff
Copy link
Member

fabaff commented Apr 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400696


x86_64-linux

✅ 6 packages built:
  • forbidden
  • forbidden.dist
  • python312Packages.bot-safe-agents
  • python312Packages.bot-safe-agents.dist
  • python313Packages.bot-safe-agents
  • python313Packages.bot-safe-agents.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit c94248d into NixOS:master Apr 28, 2025
23 of 27 checks passed
@ghost ghost deleted the forbidden branch April 28, 2025 08:42
@ghost ghost removed 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 11, 2025
@ghost ghost removed the request for review from natsukium July 11, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant