Skip to content

Conversation

@poulter7
Copy link
Contributor

@poulter7 poulter7 commented Apr 22, 2025

Only include the mpris build feature on Linux.

This makes the build consistent with lowfi's stated support: https://github.com/talwat/lowfi?tab=readme-ov-file

"MPRIS is currently optional feature in cargo (enabled with --features mpris) due to it being only for Linux"
and indeed this will build but not run on Darwin without this change.

Screenshot 2025-04-21 at 11 52 50 PM

With this change, the binary works on Darwin.
Screenshot 2025-04-22 at 12 08 52 AM

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • N/A [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • N/A [ ] (Module updates) Added a release notes entry if the change is significant
    • N/A [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 22, 2025
@poulter7 poulter7 marked this pull request as ready for review April 22, 2025 05:06
@nix-owners nix-owners bot requested a review from ZarredFelicite April 22, 2025 05:15
Copy link
Contributor

@ZarredFelicite ZarredFelicite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 26, 2025
@pbsds pbsds merged commit ae6167e into NixOS:master May 1, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants