Skip to content

Conversation

@nanophilip
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@nix-owners nix-owners bot requested a review from ShamrockLee April 22, 2025 07:59
@ShamrockLee
Copy link
Contributor

ShamrockLee commented Apr 22, 2025

Thank you for improving the packages!

Please rebase the feature branch to include only the edukai-related changes, so that ti won't conflict with other two PRs.

@nanophilip nanophilip closed this Apr 22, 2025
@ShamrockLee
Copy link
Contributor

Could we reopen these PR?

I can help if you are not familiar with git rebase.

@nanophilip nanophilip reopened this Apr 22, 2025
@nanophilip
Copy link
Contributor Author

Yes, please. I tried to fix it with git cherry-pick, but all commits show up in the PR. I assumed a PR is limited to the commits in a specific branch.

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Apr 22, 2025

You could use git rebase and force-push the result with git push -f.

Do you want to try again yourself, or I push it for you?

@nanophilip
Copy link
Contributor Author

You please do it, thank you.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@ShamrockLee
Copy link
Contributor

@ofborg build edukai.src

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Apr 26, 2025

The whole https://language.moe.gov.tw/ ("教育部語文成果網", literally "MOE Linguistic Achievement Web") seems down. The latest Wayback Machine snapshot of the site is at 2025-04-13T10:40:30-07:00, while the latest snapshot of the edukai ZIP at 2025-04-20T01:36:39-07:00. Hope that the out-of-service state is temporary.

@ShamrockLee
Copy link
Contributor

The whole https://language.moe.gov.tw/ ("教育部語文成果網", literally "MOE Linguistic Achievement Web") seems down.

The site is back. Perhaps the service outage was because of maintenance.

@ShamrockLee
Copy link
Contributor

The whole https://language.moe.gov.tw/ ("教育部語文成果網", literally "MOE Linguistic Achievement Web") seems down.

The site is back. Perhaps the service outage was because of maintenance.

It turns out that the network in my lab cannot reach that site, while the cellular network of my phone can.

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Apr 27, 2025

Functionality tested. The following is a LibreOffice Write screenshot containing the string "雪花紛飛" ("Snowflakes are flying") with font TW-MOE-Std-Kai (the font provided by edukai) and some other fonts. The font packages are made available with Home Manager configuration home.packages with fonts.fontconfig.enable set to true.

Screenshot_20250427_234742

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@ShamrockLee
Copy link
Contributor

I rebased the feature branch to resolve merge conflicts.

@nanophilip Are you still interested in this PR?

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 20, 2025
@nanophilip
Copy link
Contributor Author

What keeps this from being merged?

@ShamrockLee
Copy link
Contributor

While this PR is closed to being merged, we need to meet the following hard requirements to proceed:

  1. The string content meta.longDescription contains an extra indentation, making the file fail the formatting check.
  2. According to the current pkgs/README.md meta-attributes policies, meta.description MUST NOT start with a definite/indefinite article.

For the meta.longDescription, I personally hope that it follows the current documentation policy to place one sentence per line.

My previous change suggestions should resolve all the above issues.

nanophilip and others added 3 commits October 21, 2025 14:32
Co-authored-by: Yueh-Shun Li <shamrocklee@posteo.net>
Co-authored-by: Yueh-Shun Li <shamrocklee@posteo.net>
@ShamrockLee
Copy link
Contributor

  • Please refrain from merging the target branch into your feature branch. Instead, please rebase your feature branch with git rebase <target branch> or git rebase --onto=<target branch> HEAD~<# of commits to rebase>.
  • If the commits containing the review suggestions are merely fixups of the previous commit, they should be fused into it either by git reset --soft and git commit --amend or by git rebase -i. (If you would like to keep the commits separate, they need to have a sensible commit title.)
  • I can do those for you for now if you like, but learning to use Git would make the collaboration smoother in the long run.
  • If you want me to guide you through it, please run the following commands and paste the result:
    git status
    git remote -v
    git show HEAD
    git show HEAD~2
    I'll give you the commands and steps I think should resolve the issue. Feel free to tell me if things go wrong.
    You could also DM me via e-mail or Matrix. My e-mail account and Matrix account is in my GitHub profile page.

@nanophilip nanophilip closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants