Fix Displaylink's suspend script when DL is not running #400779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
The current script will wait forever for the output pipe when DisplayLink is not running, this happens because flushing the bytes are done without checking if the output pipe exists. Which makes the read timeout to be ignored, and the whole script being blocked waiting for the file to exist. This changes the script to test if both pipes are up before any action, this is a good indicative that the DisplayLinkManager is running.
github-actions
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/weird-behaviour-after-suspend-gnome/38210/8 |
tscolari
added a commit
to tscolari/nixfiles
that referenced
this pull request
Apr 23, 2025
nixpkgs-ci
bot
added
the
12.first-time contribution
nixpkgs-ci
bot
added
the
9.needs: reviewer
nixpkgs-ci
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing pre-sleep script introduced by DisplayLink causes the system to halt/wait forever when the machine goes into sleep but is not plugged in to the monitor/has displayManager running.
This manifests by the system actually staying awake, and any future calls to sleep/shutdown are ignored because the system is already in the process of going to sleep. More information of the issue here: #281104
This fix is based on the fact that the current script will wait forever on the output of the DisplayLink's pipe if the DisplayLinkManager is not running (which also means the file won't exist).
The new script will check the presence of the in/out pipe files (therefore if DisplayLink is running), before trying to read from it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.