Skip to content

Conversation

@SohamG
Copy link
Contributor

@SohamG SohamG commented Apr 22, 2025

Resolve #400438

Things done

  • Add requests and jinja2 as propogatedBuildInputs to enable sgpt to work after running sgpt --install-functions
  • Add myself as maintainer along with original maintainer.

CC: @MGlolenstine

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SohamG SohamG requested a review from MGlolenstine April 22, 2025 11:13
@SohamG SohamG force-pushed the fix-sgpt-requests branch from 70e29eb to e4cd419 Compare April 22, 2025 11:17
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@MGlolenstine
Copy link
Member

MGlolenstine commented Apr 22, 2025

@SohamG I haven't used this package in a really long while and other people seem to be more active updating it than I am. Seeing that you've added yourself to maintainers, I'm down with being removed from maintainers.

Thank you for improving the nix package ecosystem :)

@SohamG
Copy link
Contributor Author

SohamG commented Apr 22, 2025

Testing strategy:

  1. ./result/bin/sgpt --install-functions
  2. ./result/bin/sgpt --functions "what are the contents of the folder .."
  3. Expected output should have the contents of the parent folder in the LLM's reply.

@SohamG
Copy link
Contributor Author

SohamG commented Apr 22, 2025

@MGlolenstine Oh, thanks for letting me know. I'll go ahead and remove you from the maintainers. Thanks for the contributions to the package so far!

Copy link
Member

@MGlolenstine MGlolenstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SohamG
Copy link
Contributor Author

SohamG commented Apr 25, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@SohamG merge not permitted (#305350):
CommitterPR: pr author is not committer
R-Ryantm Maintainer merge: pr author is not r-ryantm

@pbsds pbsds merged commit 3264c61 into NixOS:master May 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shell-gpt: Missing python module requests

3 participants