Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Apr 22, 2025

tested on an aarch64-linux system - works just fine :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@6543 6543 requested a review from MikaelFangel April 22, 2025 16:17
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@6543 6543 force-pushed the slurm-nm_supports-aarch64 branch from 6c31820 to dcdf9b9 Compare April 22, 2025 16:44
@6543 6543 requested a review from Aleksanaa April 22, 2025 19:43
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Apr 22, 2025
@MikaelFangel
Copy link
Contributor

You need to squash the commit with the first and update the commit message. ☺️

@6543 6543 force-pushed the slurm-nm_supports-aarch64 branch from 71847c3 to b88e730 Compare April 22, 2025 20:59
@6543
Copy link
Member Author

6543 commented Apr 22, 2025

done + rebased

@6543 6543 force-pushed the slurm-nm_supports-aarch64 branch from b88e730 to 516491f Compare April 22, 2025 21:02
@6543 6543 changed the title slurm-nm: make aarch64-linux as officially supported platform slurm-nm: declare all unix platforms aarch64-linux as officially supported Apr 22, 2025
@6543 6543 changed the title slurm-nm: declare all unix platforms aarch64-linux as officially supported slurm-nm: declare all unix platforms as officially supported Apr 22, 2025
@6543 6543 force-pushed the slurm-nm_supports-aarch64 branch from 516491f to 11effb9 Compare April 22, 2025 21:03
@6543
Copy link
Member Author

6543 commented Apr 22, 2025

commit message and pr title fixed too

@Aleksanaa
Copy link
Member

Built on aarch64-darwin

@Aleksanaa Aleksanaa merged commit 835524c into NixOS:master Apr 23, 2025
24 of 27 checks passed
@6543 6543 deleted the slurm-nm_supports-aarch64 branch April 23, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants