Skip to content

php81Extensions.ctype: fix build #400894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drupol merged 1 commit into from
Apr 22, 2025
Merged

php81Extensions.ctype: fix build #400894

drupol merged 1 commit into from
Apr 22, 2025

Conversation

@piotrkwiecinski
Copy link
Contributor

@piotrkwiecinski piotrkwiecinski commented Apr 22, 2025

https://hydra.nixos.org/build/295112397/nixlog/2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: php PHP is a general-purpose scripting language geared towards web development. label Apr 22, 2025
@nix-owners nix-owners bot requested review from Ma27, aanderse, globin, jtojnar and talyz April 22, 2025 17:59
drupol
drupol reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this fixing the issue ? I don't get it

@piotrkwiecinski
Copy link
Contributor Author

piotrkwiecinski commented Apr 22, 2025 •
edited
Loading

-f flag suppresses an error and returns 0 if file doesn't exist

[piotr@thinkpad-x1-g3:~/projects/opensource/nixos-nixpkgs]$ rm  /tmp/blastsata
rm: cannot remove '/tmp/blastsata': No such file or directory

[piotr@thinkpad-x1-g3:~/projects/opensource/nixos-nixpkgs]$ rm -f /tmp/blastsata

[piotr@thinkpad-x1-g3:~/projects/opensource/nixos-nixpkgs]$

@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 22, 2025
@drupol
Copy link
Contributor

drupol commented Apr 22, 2025

Perhaps we should avoid doing that ? so that we can correctly know where the patch is being applied ?

GaetanLepage
GaetanLepage reviewed Apr 22, 2025
View reviewed changes
drupol
drupol approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Apr 22, 2025
@drupol drupol merged commit 58af570 into NixOS:master Apr 22, 2025
24 of 27 checks passed
@drupol
Copy link
Contributor

drupol commented Apr 22, 2025

w00t, thank you!

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 22, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Apr 22, 2025
Merged
1 task
@piotrkwiecinski piotrkwiecinski deleted the php-ctype-81 branch April 22, 2025 19:01
drupol added a commit to fossar/nix-phps that referenced this pull request Apr 27, 2025
@drupol
ctype: adjust version constraints
c2f9048 
context: NixOS/nixpkgs#400894
@drupol drupol mentioned this pull request Apr 27, 2025
Merged
jtojnar pushed a commit to fossar/nix-phps that referenced this pull request Apr 28, 2025
@drupol @jtojnar
ctype: adjust version constraints
9903b4b 
context: NixOS/nixpkgs#400894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage left review comments

@drupol drupol drupol approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@jtojnar jtojnar Awaiting requested review from jtojnar

@aanderse aanderse Awaiting requested review from aanderse

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

Assignees

No one assigned

Labels

6.topic: php PHP is a general-purpose scripting language geared towards web development. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piotrkwiecinski @drupol @GaetanLepage